netdev - Re: [PATCH net-next] ipv6: Simplify rt6_qualify_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 21 Apr 2019 20:31:23 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     David Ahern <dsahern@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, idosch@...lanox.com,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next] ipv6: Simplify rt6_qualify_for_ecmp

On Sun, Apr 21, 2019 at 08:49:01AM -0700, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> After commit c7a1ce397ada ("ipv6: Change addrconf_f6i_alloc to use
> ip6_route_info_create"), the gateway is no longer filled in for fib6_nh
> structs in a prefix route. Accordingly, the RTF_ADDRCONF flag check can
> be dropped from the 'rt6_qualify_for_ecmp'.
> 
> Further, RTF_DYNAMIC is only set in rt6_info instances, so it can be
> removed from the check as well.
> 
> This reduces rt6_qualify_for_ecmp and the mlxsw version to just checking
> if the nexthop has a gateway which is the real indication of whether
> entries can be coalesced into a multipath route.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

Reviewed-by: Ido Schimmel <idosch@...lanox.com>