lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 22 Apr 2019 11:07:04 -0700
From:   Cong Wang <>
To:     Andre Guedes <>
Cc:     Linux Kernel Network Developers <>,
        Vinicius Costa Gomes <>
Subject: Re: [PATCH 3/5] net: sched: taprio: Fix null pointer deref bug

On Mon, Apr 22, 2019 at 11:04 AM Cong Wang <> wrote:
> On Fri, Apr 19, 2019 at 6:06 PM Andre Guedes <> wrote:
> >
> > If 'entry' is NULL we WARN_ON() but dereference the pointer anyway,
> > generating a null pointer dereference bug. This patch fixes should_
> > restart_cycle() so we return if the pointer is NULL.
> Hmm, while you are on it, how is it possible to have entry==NULL
> for should_restart_cycle(). It is only called in advance_sched()
> where entry is already checked against NULL right before it,
> so for me, entry is always NULL at the point of calling
> should_restart_cycle().

I meant, 'entry' is always non-NULL here... I typed too fast.

Powered by blists - more mailing lists