netdev - Re: [patch net-next v2 08/16] netdevsim: add bus attributes to add new and delete devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190422122302.14c8296f@cakuba.netronome.com>
Date:   Mon, 22 Apr 2019 12:23:02 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        dsahern@...il.com
Subject: Re: [patch net-next v2 08/16] netdevsim: add bus attributes to add
 new and delete devices

On Sat, 20 Apr 2019 12:29:14 +0200, Jiri Pirko wrote:
> +static ssize_t del_device_store(struct bus_type *bus, const char *buf,
> +				size_t count)

Please use the existing format of breaking  multiline function
declaration, if retype is longer than 3 chars it should be on a
separate line:

type
name(arg, arg, ..
     arg, arg)

Please fix everywhere.