netdev - Re: [PATCH 4.14 stable 2/5] net: IP defrag: encapsulate rbtree defrag code into callable functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Apr 2019 09:09:36 -0700
From:   Peter Oskolkov <posk@...k.io>
To:     Lars Persson <lists@...h.nu>
Cc:     Peter Oskolkov <posk@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, linux-netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Sasha Levin <sashal@...nel.org>,
        Captain Wiggum <captwiggum@...il.com>,
        Florian Westphal <fw@...len.de>,
        Tom Herbert <tom@...bertland.com>
Subject: Re: [PATCH 4.14 stable 2/5] net: IP defrag: encapsulate rbtree defrag
 code into callable functions

On Tue, Apr 23, 2019 at 5:07 AM Lars Persson <lists@...h.nu> wrote:
>
> On Tue, Apr 23, 2019 at 12:29 AM Peter Oskolkov <posk@...gle.com> wrote:
> >
> > [ Upstream commit c23f35d19db3b36ffb9e04b08f1d91565d15f84f ]
> >
> > This is a refactoring patch: without changing runtime behavior,
> > it moves rbtree-related code from IPv4-specific files/functions
> > into .h/.c defrag files shared with IPv6 defragmentation code.
> >
> > Signed-off-by: Peter Oskolkov <posk@...gle.com>
> > Cc: Eric Dumazet <edumazet@...gle.com>
> > Cc: Florian Westphal <fw@...len.de>
> > Cc: Tom Herbert <tom@...bertland.com>
> > Signed-off-by: David S. Miller <davem@...emloft.net>
> > ---
> >  include/net/inet_frag.h  |  16 ++-
> >  net/ipv4/inet_fragment.c | 293 +++++++++++++++++++++++++++++++++++++++
> >  net/ipv4/ip_fragment.c   | 290 ++++----------------------------------
> >  3 files changed, 335 insertions(+), 264 deletions(-)
> >
> Hi
>
> We get a compile error with gcc 8.2 after applying this patch:
>  net/ipv4/ip_fragment.c: In function 'ip_frag_queue':
>  net/ipv4/ip_fragment.c:390:1: error: label 'discard_qp' defined but
> not used [-Werror=unused-label]
>   discard_qp:

Thanks for the report: I'll send a v2.