netdev - Re: [net-next 06/14] net/mlx5e: XDP, Inline small packets into the TX MPWQE in XDP xmit flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98e23c3228b4e57638b5e57cfbeef21cc25875f0.camel@mellanox.com>
Date:   Tue, 23 Apr 2019 16:46:13 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "galpress@...zon.com" <galpress@...zon.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Shay Agroskin <shayag@...lanox.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        "brouer@...hat.com" <brouer@...hat.com>, "bsd@...com" <bsd@...com>
Subject: Re: [net-next 06/14] net/mlx5e: XDP, Inline small packets into the TX
 MPWQE in XDP xmit flow

On Tue, 2019-04-23 at 15:53 +0300, Gal Pressman wrote:
> On 23-Apr-19 01:32, Saeed Mahameed wrote:
> >  static inline void
> > -mlx5e_xdp_mpwqe_add_dseg(struct mlx5e_xdpsq *sq, dma_addr_t
> > dma_addr, u16 dma_len)
> > +mlx5e_xdp_mpwqe_add_dseg(struct mlx5e_xdpsq *sq, struct
> > mlx5e_xdp_info *xdpi,
> > +			 struct mlx5e_xdpsq_stats *stats)
> 
> Passing stats as a function parameter is weird, why not remove and
> use sq->stats?
> 

This is the core function to put the packet pointer into the hw ring
buffer, it is very performance critical, and since the sq->stats now is
a pointer we want to avoid two ptr de-references (sq->stats-
>tx_pacets); we read the sq->stats once and provide it all the way down
to lower level functions.