netdev - Re: [PATCH 1/2] spi: Micrel eth switch: declare missing of table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190423.104539.760666797421402541.davem@davemloft.net>
Date:   Tue, 23 Apr 2019 10:45:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dagmcr@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org, javier@...hile0.org
Subject: Re: [PATCH 1/2] spi: Micrel eth switch: declare missing of table

From: Daniel Gomez <dagmcr@...il.com>
Date: Mon, 22 Apr 2019 21:08:03 +0200

> Add missing <of_device_id> table for SPI driver relying on SPI
> device match since compatible is in a DT binding or in a DTS.
> 
> Before this patch:
> modinfo drivers/net/phy/spi_ks8995.ko | grep alias
> alias:          spi:ksz8795
> alias:          spi:ksz8864
> alias:          spi:ks8995
> 
> After this patch:
> modinfo drivers/net/phy/spi_ks8995.ko | grep alias
> alias:          spi:ksz8795
> alias:          spi:ksz8864
> alias:          spi:ks8995
> alias:          of:N*T*Cmicrel,ksz8795C*
> alias:          of:N*T*Cmicrel,ksz8795
> alias:          of:N*T*Cmicrel,ksz8864C*
> alias:          of:N*T*Cmicrel,ksz8864
> alias:          of:N*T*Cmicrel,ks8995C*
> alias:          of:N*T*Cmicrel,ks8995
> 
> Reported-by: Javier Martinez Canillas <javier@...hile0.org>
> Signed-off-by: Daniel Gomez <dagmcr@...il.com>

The discussion of where these drivers should really live is interesting,
but these two changes are valid so I am applying them.

Applied.