netdev - Re: [PATCH bpf-next v2 2/2] selftests/bpf: expand test_tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6acd1ab9-bb7b-fb17-6fc5-d0135aa78005@fb.com>
Date:   Tue, 23 Apr 2019 21:10:03 +0000
From:   Yonghong Song <yhs@...com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "alan.maguire@...cle.com" <alan.maguire@...cle.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH bpf-next v2 2/2] selftests/bpf: expand test_tc_tunnel with
 SIT encap



On 4/23/19 11:43 AM, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> So far, all BPF tc tunnel testcases encapsulate in the same network
> protocol. Add an encap testcase that requires updating skb->protocol.
> 
> The 6in4 tunnel encapsulates an IPv6 packet inside an IPv4 tunnel.
> Verify that bpf_skb_net_grow correctly updates skb->protocol to
> select the right protocol handler in __netif_receive_skb_core.
> 
> The BPF program should also manually update the link layer header to
> encode the right network protocol.
> 
> Changes v1->v2
>    - improve documentation of non-obvious logic
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
> Tested-by: Alan Maguire <alan.maguire@...cle.com>

Acked-by: Yonghong Song <yhs@...com>