netdev - Re: [PATCH v2 net-next 06/14] dsa: Add boilerplate helper to register DSA tag driver modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190423165251.796edad5@cakuba.netronome.com>
Date:   Tue, 23 Apr 2019 16:52:51 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH v2 net-next 06/14] dsa: Add boilerplate helper to
 register DSA tag driver modules

On Tue, 23 Apr 2019 02:22:49 +0200, Andrew Lunn wrote:
> +/**
> + * module_dsa_tag_drivers() - Helper macro for registering DSA tag
> + * drivers
> + * @__ops_array: Array of tag driver strucutres
> + *
> + * Helper macro for DSA tag drivers which do not do anything special
> + * in module init/exit. Each module may only use this macro once, and
> + * calling it replaces module_init() and module_exit().
> + */

nit: looks like kdoc is misplaced

> +#define dsa_tag_driver_module_drivers(__dsa_tag_drivers_array, __count)	\
> +static int __init dsa_tag_driver_module_init(void)			\
> +{									\
> +	dsa_tag_drivers_register(__dsa_tag_drivers_array, __count,	\
> +					THIS_MODULE);			\

nit: THIS_MODULE doesn't align