netdev - Re: [net-next 01/14] net/mlx5e: RX, Add a prefetch command for small L1_CACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190422194647.372fd817@cakuba.netronome.com>
Date:   Mon, 22 Apr 2019 19:46:47 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        Tariq Toukan <tariqt@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Jonathan Lemon <bsd@...com>
Subject: Re: [net-next 01/14] net/mlx5e: RX, Add a prefetch command for
 small L1_CACHE_BYTES

On Mon, 22 Apr 2019 15:32:53 -0700, Saeed Mahameed wrote:
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> index 51e109fdeec1..6147be23a9b9 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> @@ -50,6 +50,7 @@
>  #include <net/xdp.h>
>  #include <linux/net_dim.h>
>  #include <linux/bits.h>
> +#include <linux/prefetch.h>
>  #include "wq.h"
>  #include "mlx5_core.h"
>  #include "en_stats.h"
> @@ -986,6 +987,22 @@ static inline void mlx5e_cq_arm(struct mlx5e_cq *cq)
>  	mlx5_cq_arm(mcq, MLX5_CQ_DB_REQ_NOT, mcq->uar->map, cq->wq.cc);
>  }
>  
> +static inline void mlx5e_prefetch(void *p)
> +{
> +	prefetch(p);
> +#if L1_CACHE_BYTES < 128
> +	prefetch(p + L1_CACHE_BYTES);
> +#endif
> +}
> +
> +static inline void mlx5e_prefetchw(void *p)
> +{
> +	prefetchw(p);
> +#if L1_CACHE_BYTES < 128
> +	prefetchw(p + L1_CACHE_BYTES);
> +#endif
> +}

All Intel drivers do the exact same thing, perhaps it's time to add a
helper fot this?

net_prefetch_headers()

or some such?