netdev - Re: [PATCH 0/3] PCI: add help pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190422.210955.874397955396314386.davem@davemloft.net>
Date:   Mon, 22 Apr 2019 21:09:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     helgaas@...nel.org
Cc:     hkallweit1@...il.com, linux-pci@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH 0/3] PCI: add help pci_dev_id

From: Bjorn Helgaas <helgaas@...nel.org>
Date: Mon, 22 Apr 2019 08:20:20 -0500

> On Fri, Apr 19, 2019 at 03:13:38PM -0700, David Miller wrote:
>> From: Heiner Kallweit <hkallweit1@...il.com>
>> Date: Fri, 19 Apr 2019 20:27:45 +0200
>> 
>> > In several places in the kernel we find PCI_DEVID used like this:
>> > PCI_DEVID(dev->bus->number, dev->devfn) Therefore create a helper
>> > for it.
>> 
>> I'll wait for an ACK from the PCI folks on patch #1.
> 
> #1 and #2 touch PCI, #3 is a trivial r8169 patch.  There are a few
> other places where this helper could be used (powernv/npu-dma.c,
> amdkfd/kfd_topology.c, amd_iommu.c, intel-iommu.c,
> intel_irq_remapping.c, stmmac_pci.c, chromeos_laptop.c).
> 
> I think it would be easier for me to collect acks for the trivial
> changes to those places and merge the whole shebang via PCI.

That's fine with me, you can add my:

Acked-by: David S. Miller <davem@...emloft.net>