netdev - Re: ipsec tunnel performance degrade

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190423055645.rzuau3yb64wkwwyc@breakpoint.cc>
Date:   Tue, 23 Apr 2019 07:56:45 +0200
From:   Florian Westphal <fw@...len.de>
To:     Vakul Garg <vakul.garg@....com>
Cc:     Florian Westphal <fw@...len.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: ipsec tunnel performance degrade

Vakul Garg <vakul.garg@....com> wrote:
> > Do you use xfrm interfaces?
> 
> I don't think so. I use setkey to create policies/SAs.
> Can you please give me some hint about it?

Then you're not using ipsec interfaces.

> > > Further, perf show that a lot of atomic primitives such as
> > > __ll_sc___cmpxchg_case_mb_4(),
> > > __ll_sc_atomic_sub_return() are being invoked. On 16 core system, they
> > consume more than 30% of cpu.
> > 
> > Thats not good, perhaps we should look at pcpu refcounts for the xfrm state
> > structs.
> 
> What else data can I collect?

I have no further suggestions.  I don't know yet when I will have time
to look into refcnt optimizations.

Idea would be to make them same as dev_hold/put.