netdev - Re: [PATCH 0/5] isdn: deprecate non-mISDN drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Apr 2019 12:24:41 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg KH <gregkh@...uxfoundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Karsten Keil <isdn@...ux-pingi.de>,
        Networking <netdev@...r.kernel.org>,
        isdn4linux@...tserv.isdn4linux.de, Paul Bolle <pebolle@...cali.nl>,
        Holger Schurig <holgerschurig@...glemail.com>,
        Tilman Schmidt <tilman@...p.cc>,
        Al Viro <viro@...iv.linux.org.uk>,
        gigaset307x-common@...ts.sourceforge.net,
        Johan Hedberg <johan.hedberg@...il.com>,
        Bluez mailing list <linux-bluetooth@...r.kernel.org>
Subject: Re: [PATCH 0/5] isdn: deprecate non-mISDN drivers

Hi Arnd,

>>> When isdn4linux came up in the context of another patch series, I
>>> remembered that we had discussed removing it a while ago.
>> 
>> This seems long overdue to me.
>> 
>> Could you please respin against net-next and I'll just apply this?
> 
> Ok. I'll send a pull request then, which should make it easier to deal with
> the file removals, as I'm never sure whether 'git format-patch -D' patches
> make it across the list correctly, at least I had problems applying them
> in the past.
> 
> I added a few fixups as in the diff below in the meantime, to deal
> with build regressions from the last patch. In particular, the BT_CMTP
> (CIP) code also needs to be moved into staging along with the CAPI
> core. From what I can find, this was originally used for dial-up
> internet connections with 'Bluefritz' ISDN hardware, but it stopped
> working many years ago and is no longer useful with after the
> public network shutdown either.
> 
>     Arnd
> 
> 
> diff --git a/drivers/staging/isdn/Kconfig b/drivers/staging/isdn/Kconfig
> index 77e1b80af716..29d13fcd9e2b 100644
> --- a/drivers/staging/isdn/Kconfig
> +++ b/drivers/staging/isdn/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ISDN_CAPI
>  tristate "CAPI 2.0 subsystem"
> + depends on NET && NETDEVICES
>  help
>    This provides CAPI (the Common ISDN Application Programming
>    Interface) Version 2.0, a standard making it easy for programs to
> @@ -23,6 +24,7 @@ source "drivers/staging/isdn/gigaset/Kconfig"
> 
> source "drivers/staging/isdn/hysdn/Kconfig"
> 
> +source "drivers/staging/isdn/cmtp/Kconfig"
> 
> endif # ISDN_CAPI

NAK.

I do not care about isdn4linux, but this is a purely CAPI based driver. So removing (or moving to staging) CAPI support seems rather premature.

Maybe someone would have started talking to us before trying to move this into staging. It is a maintained driver. That it is rather simple and hasn’t seen patches in a long time, doesn’t mean it is not maintained and staging material. I see no reason to tell any user to enable staging tree to get CMTP support.

Regards

Marcel