netdev - Re: [PATCH] net: socket: Exit earlier from __sock_create if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190423.184326.752119310161940759.davem@davemloft.net>
Date:   Tue, 23 Apr 2019 18:43:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Haiqing.Bai@...driver.com
Cc:     netdev@...r.kernel.org, Abdel.Elmahrad@...driver.com
Subject: Re: [PATCH] net: socket: Exit earlier from __sock_create if
 CONFIG_IPV6 is disabled

From: Haiqing Bai <Haiqing.Bai@...driver.com>
Date: Tue, 23 Apr 2019 17:00:23 +0800

> diff --git a/net/socket.c b/net/socket.c
> index 8255f5bda0aa..7927c2bcad65 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -1339,6 +1339,11 @@ int __sock_create(struct net *net, int family, int type, int protocol,
>  	if (type < 0 || type >= SOCK_MAX)
>  		return -EINVAL;
>  
> +#if !(IS_ENABLED(CONFIG_IPV6))
> +	if (family == AF_INET6)
> +		return -EAFNOSUPPORT;
> +#endif

There is no way I am allowing this kind of layering violation.  It's
just rediculous.