lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 23 Apr 2019 18:44:33 -0700
From:   Jakub Kicinski <>
To:     Tao Ren <>
Cc:     "David S . Miller" <>,
        Maxim Mikityanskiy <>,
        Bartosz Golaszewski <>,
        Samuel Mendoza-Jonas <>,
        Joel Stanley <>,
        Andrew Jeffery <>,
        "" <>,
        "" <>,
        "" <>
Subject: Re: [PATCH net v4] net/ncsi: handle overflow when incrementing mac

On Wed, 24 Apr 2019 01:43:32 +0000, Tao Ren wrote:
> Previously BMC's MAC address is calculated by simply adding 1 to the
> last byte of network controller's MAC address, and it produces incorrect
> result when network controller's MAC address ends with 0xFF.
> The problem can be fixed by calling eth_addr_inc() function to increment
> MAC address; besides, the MAC address is also validated before assigning
> to BMC.
> Fixes: cb10c7c0dfd9 ("net/ncsi: Add NCSI Broadcom OEM command")
> Signed-off-by: Tao Ren <>

Acked-by: Jakub Kicinski <>

Powered by blists - more mailing lists