netdev - Re: [PATCH net-next] tipc: tipc_udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190424.114715.27778182719498821.davem@davemloft.net>
Date:   Wed, 24 Apr 2019 11:47:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        jon.maloy@...csson.com, ying.xue@...driver.com
Subject: Re: [PATCH net-next] tipc: tipc_udp_recv() cleanup vs rcu verbs

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue, 23 Apr 2019 09:24:46 -0700

> First thing tipc_udp_recv() does is to use rcu_dereference_sk_user_data(),
> and this is really hinting we already own rcu_read_lock() from the caller
> (UDP stack).
> 
> No need to add another rcu_read_lock()/rcu_read_unlock() pair.
> 
> Also use rcu_dereference() instead of rcu_dereference_rtnl()
> in the data path.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.