lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 24 Apr 2019 14:47:46 -0500
From:   "Gustavo A. R. Silva" <>
To:     Arnd Bergmann <>
Cc:     "David S. Miller" <>,
        Networking <>,
        Linux Kernel Mailing List <>,
        Dan Carpenter <>
Subject: Re: [PATCH net-next] net: socket: Fix missing break in switch


On 4/24/19 1:45 PM, Arnd Bergmann wrote:
> On Wed, Apr 24, 2019 at 5:33 PM Gustavo A. R. Silva
> <> wrote:
>> Add missing break statement in order to prevent the code from falling
>> through to cases SIOCGSTAMP_NEW and SIOCGSTAMPNS_NEW.
>> This bug was found thanks to the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>> Fixes: 0768e17073dc ("net: socket: implement 64-bit timestamps")
>> Signed-off-by: Gustavo A. R. Silva <>
> Reported-by: Dan Carpenter <>

Just for clarification: Dan didn't report this to me. I found this
bug while working on the last fall-through warnings in net.

> Acked-by: Arnd Bergmann <>
> I had just prepared the same patch after Dan told me about the issue today,
> but you managed to submit it first.
> Thanks for the fix!

Glad to help. :)


Powered by blists - more mailing lists