netdev - Re: [PATCH net] net/rose: fix unbound loop in rose_loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190424.144010.1716935547360505290.davem@davemloft.net>
Date:   Wed, 24 Apr 2019 14:40:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net] net/rose: fix unbound loop in rose_loopback_timer()

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 24 Apr 2019 05:35:00 -0700

> This patch adds a limit on the number of skbs that fuzzers can queue
> into loopback_queue. 1000 packets for rose loopback seems more than enough.
> 
> Then, since we now have multiple cpus in most linux hosts,
> we also need to limit the number of skbs rose_loopback_timer()
> can dequeue at each round.
> 
> rose_loopback_queue() can be drop-monitor friendly, calling
> consume_skb() or kfree_skb() appropriately.
> 
> Finally, use mod_timer() instead of del_timer() + add_timer()
> 
> syzbot report was :
 ...
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable.

Thanks.