netdev - Re: [PATCH net] net: phy: marvell: Fix buffer overrun with stats counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f71db3f5-5ddc-ac51-c57f-8e473925523f@gmail.com>
Date:   Wed, 24 Apr 2019 15:48:53 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH net] net: phy: marvell: Fix buffer overrun with stats
 counters

On 4/24/19 3:33 PM, Andrew Lunn wrote:
> marvell_get_sset_count() returns how many statistics counters there
> are. If the PHY supports fibre, there are 3, otherwise two.
> 
> marvell_get_strings() does not make this distinction, and always
> returns 3 strings. This then often results in writing passed the end
> of the buffer for the strings.
> 
> Fixes: 2170fef78a40 ("Marvell phy: add field to get errors from fiber link.")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian