netdev - Re: [PATCH 1/5] isdn: gigaset: remove i4l support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Apr 2019 10:53:36 +0200
From:   Paul Bolle <pebolle@...cali.nl>
To:     Arnd Bergmann <arnd@...db.de>, Karsten Keil <isdn@...ux-pingi.de>,
        netdev@...r.kernel.org
Cc:     isdn4linux@...tserv.isdn4linux.de,
        Holger Schurig <holgerschurig@...glemail.com>,
        Tilman Schmidt <tilman@...p.cc>,
        Al Viro <viro@...iv.linux.org.uk>,
        gigaset307x-common@...ts.sourceforge.net
Subject: Re: [PATCH 1/5] isdn: gigaset: remove i4l support

Arnd Bergmann schreef op di 23-04-2019 om 17:11 [+0200]:
> --- a/drivers/isdn/gigaset/Kconfig
> +++ b/drivers/isdn/gigaset/Kconfig
> @@ -1,6 +1,7 @@
>  menuconfig ISDN_DRV_GIGASET
>  	tristate "Siemens Gigaset support"
>  	depends on TTY
> +	depends on ISDN_CAPI
>  	select CRC_CCITT
>  	select BITREVERSE
>  	help
> @@ -17,27 +18,6 @@ menuconfig ISDN_DRV_GIGASET
>  
>  if ISDN_DRV_GIGASET
>  
> -config GIGASET_CAPI
> -	bool "Gigaset CAPI support"
> -	depends on ISDN_CAPI='y'||(ISDN_CAPI='m'&&ISDN_DRV_GIGASET='m')
> -	default 'y'
> -	help
> -	  Build the Gigaset driver as a CAPI 2.0 driver interfacing with
> -	  the Kernel CAPI subsystem. To use it with the old ISDN4Linux
> -	  subsystem you'll have to enable the capidrv glue driver.
> -	  (select ISDN_CAPI_CAPIDRV.)
> -	  Say N to build the old native ISDN4Linux variant.
> -	  If unsure, say Y.
> -
> -config GIGASET_I4L
> -	bool
> -	depends on ISDN_I4L='y'||(ISDN_I4L='m'&&ISDN_DRV_GIGASET='m')
> -	default !GIGASET_CAPI
> -
> -config GIGASET_DUMMYLL
> -	bool
> -	default !GIGASET_CAPI&&!GIGASET_I4L
> -

The dummyll code allows people using gigaset hardware for voice only to fiddle
with its settings, retrieve call logs, etc. So in theory dropping i4l support
doesn't require dropping dummyll support.

>  config GIGASET_BASE
>  	tristate "Gigaset base station support"
>  	depends on USB

Thanks,


Paul Bolle