netdev - Re: [PATCH][next] rndis_wlan: use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190425163806.B7C8D60736@smtp.codeaurora.org>
Date:   Thu, 25 Apr 2019 16:38:06 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Jussi Kivilinna <jussi.kivilinna@....fi>,
        "David S. Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH][next] rndis_wlan: use struct_size() helper

"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:

> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes, in particular in the
> context in which this code is being used.
> 
> So, replace code of the following form:
> 
> sizeof(*pmkids) + max_pmkids * sizeof(pmkids->bssid_info[0])
> 
> with:
> 
> struct_size(pmkids, bssid_info, num_pmkids)
> 
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Patch applied to wireless-drivers-next.git, thanks.

d442af2e1bcb rndis_wlan: use struct_size() helper

-- 
https://patchwork.kernel.org/patch/10884341/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches