netdev - Re: [PATCH net-next] ibmvnic: Add device identification to requested IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190425165109.GA12859@kashyyyk>
Date:   Thu, 25 Apr 2019 13:51:09 -0300
From:   Mauro Rodrigues <maurosr@...ux.vnet.ibm.com>
To:     Murilo Fossa Vicentini <muvic@...ux.ibm.com>
Cc:     netdev@...r.kernel.org, tlfalcon@...ux.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Add device identification to requested
 IRQs

On Thu, Apr 25, 2019 at 11:02:33AM -0300, Murilo Fossa Vicentini wrote:
> The ibmvnic driver currently uses the same fixed name when using
> request_irq, this makes it hard to parse when multiple VNIC devices are
> available at the same time. This patch adds the unit_address as the device
> identification along with an id for each queue.
> 
> The original idea was to use the interface name as an identifier, but it
> is not feasible given these requests happen at adapter probe, and at this
> point netdev is not yet registered so it doesn't have the proper name
> assigned to it.
> 
> Signed-off-by: Murilo Fossa Vicentini <muvic@...ux.ibm.com>
Reviewed-by: Mauro S. M. Rodrigues <maurosr@...ux.vnet.ibm.com>

This is very useful, thanks!