netdev - Re: [PATCH net-next 1/4] net/tls: don't log errors every time offload can't proceed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Apr 2019 12:15:48 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "davejwatson@...com" <davejwatson@...com>,
        "oss-drivers@...ronome.com" <oss-drivers@...ronome.com>,
        Boris Pismenny <borisp@...lanox.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        Aviad Yehezkel <aviadye@...lanox.com>,
        "alexei.starovoitov@...il.com" <alexei.starovoitov@...il.com>,
        "simon.horman@...ronome.com" <simon.horman@...ronome.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/4] net/tls: don't log errors every time
 offload can't proceed

On Thu, 25 Apr 2019 18:37:19 +0000, Saeed Mahameed wrote:
> On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote:
> > Currently when CONFIG_TLS_DEVICE is set each time kTLS
> > connection is opened and the offload is not successful
> > (either because the underlying device doesn't support
> > it or e.g. it's tables are full) a rate limited error
> > will be printed to the logs.
> > 
> > There is nothing wrong with failing TLS offload.  SW
> > path will process the packets just fine, avoid the
> > noisy messages by demoting them from error to debug
> > level.
> > 
> > Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> > Reviewed-by: Reviewed-by: Simon Horman <simon.horman@...ronome.com>  
> 
> Did simon review this patch twice ;) ?
> please fixup "Reviewed-by:" Tag.

Ups :)

> and also i think it shouldn't be even debug, it should be silent.
> The device didn't advertise the feature, why would we print a debug
> message on every TLS connection ?

Coin toss :)  I was wondering if the original author seen some value 
in those.  I have some tls tracepoints queued, those should cover set.