netdev - Re: [PATCH v3 bpf-next 4/4] bpftool: fix indendation in bash-completion/bpftool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <74389a6e-2a72-2ee1-b5c9-c94ece3a7581@netronome.com>
Date:   Thu, 25 Apr 2019 20:21:09 +0100
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Andrii Nakryiko <andriin@...com>, andrii.nakryiko@...il.com,
        kernel-team@...com, netdev@...r.kernel.org, bpf@...r.kernel.org,
        ast@...com, daniel@...earbox.net, yhs@...com,
        songliubraving@...com, kafai@...com, acme@...nel.org
Subject: Re: [PATCH v3 bpf-next 4/4] bpftool: fix indendation in
 bash-completion/bpftool

2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko <andriin@...com>
> Fix misaligned default case branch for `prog dump` sub-command.
> 
> Reported-by: Quentin Monnet <quentin.monnet@...ronome.com>
> Cc: Yonghong Song <yhs@...com>
> Signed-off-by: Andrii Nakryiko <andriin@...com>
> ---
>   tools/bpf/bpftool/bash-completion/bpftool | 22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool
> index bca91d04ed35..50e402a5a9c8 100644
> --- a/tools/bpf/bpftool/bash-completion/bpftool
> +++ b/tools/bpf/bpftool/bash-completion/bpftool
> @@ -273,17 +273,17 @@ _bpftool()
>                                   "$cur" ) )
>                               return 0
>                               ;;
> -                    *)
> -                        _bpftool_once_attr 'file'
> -                        if _bpftool_search_list 'xlated'; then
> -                            COMPREPLY+=( $( compgen -W 'opcodes visual linum' -- \
> -                                "$cur" ) )
> -                        else
> -                            COMPREPLY+=( $( compgen -W 'opcodes linum' -- \
> -                                "$cur" ) )
> -                        fi
> -                        return 0
> -                        ;;
> +                        *)
> +                            _bpftool_once_attr 'file'
> +                            if _bpftool_search_list 'xlated'; then
> +                                COMPREPLY+=( $( compgen -W 'opcodes visual linum' -- \
> +                                    "$cur" ) )
> +                            else
> +                                COMPREPLY+=( $( compgen -W 'opcodes linum' -- \
> +                                    "$cur" ) )
> +                            fi
> +                            return 0
> +                            ;;
>                       esac
>                       ;;
>                   pin)
> 

Thanks for that!
Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>