netdev - Re: [PATCH bpf-next v5 1/2] bpf: support BPF_PROG_QUERY for BPF_FLOW_DISSECTOR attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06278cf1-2fa3-e338-533a-4157acaa5bb1@iogearbox.net>
Date:   Thu, 25 Apr 2019 23:51:24 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Stanislav Fomichev <sdf@...gle.com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     davem@...emloft.net, ast@...nel.org, Jann Horn <jannh@...gle.com>
Subject: Re: [PATCH bpf-next v5 1/2] bpf: support BPF_PROG_QUERY for
 BPF_FLOW_DISSECTOR attach_type

On 04/25/2019 11:37 PM, Stanislav Fomichev wrote:
> target_fd is target namespace. If there is a flow dissector BPF program
> attached to that namespace, its (single) id is returned.
> 
> v5:
> * drop net ref right after rcu unlock (Daniel Borkmann)
> 
> v4:
> * add missing put_net (Jann Horn)
> 
> v3:
> * add missing inline to skb_flow_dissector_prog_query static def
>   (kbuild test robot <lkp@...el.com>)
> 
> v2:
> * don't sleep in rcu critical section (Jakub Kicinski)
> * check input prog_cnt (exit early)
> 
> Cc: Jann Horn <jannh@...gle.com>
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

Looks good, applied, thanks!