lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190426142103.GI14432@lunn.ch> Date: Fri, 26 Apr 2019 16:21:03 +0200 From: Andrew Lunn <andrew@...n.ch> To: Esben Haabendal <esben@...nix.com> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Michal Simek <michal.simek@...inx.com>, Luis Chamberlain <mcgrof@...nel.org>, YueHaibing <yuehaibing@...wei.com>, Yang Wei <yang.wei9@....com.cn>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 08/12] net: ll_temac: Fix iommu/swiotlb leak On Fri, Apr 26, 2019 at 09:32:27AM +0200, Esben Haabendal wrote: > Unmap the actual buffer length, not the amount of data received. Hi Esben The patch Subject does not seem to match the content? Also, there can be performance advantages of just unmapping the received length. The unmap operation does a cache invalidate, which can be expensive. Consider the effort of unmapping a 64 byte ACK vs 9K jumbo frame? Andrew > Signed-off-by: Esben Haabendal <esben@...nix.com> > --- > drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c > index 309f149..56d8077 100644 > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > @@ -821,7 +821,7 @@ static void ll_temac_recv(struct net_device *ndev) > length = be32_to_cpu(cur_p->app4) & 0x3FFF; > > dma_unmap_single(ndev->dev.parent, be32_to_cpu(cur_p->phys), > - length, DMA_FROM_DEVICE); > + XTE_MAX_JUMBO_FRAME_SIZE, DMA_FROM_DEVICE); > > skb_put(skb, length); > skb->protocol = eth_type_trans(skb, ndev); > -- > 2.4.11 >
Powered by blists - more mailing lists