netdev - Re: [PATCH net-next 2/6] xsk: Add API to check for available entries in FQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190426151854.3xihtrcat3e3sgqq@ast-mbp.dhcp.thefacebook.com>
Date:   Fri, 26 Apr 2019 08:18:56 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Maxim Mikityanskiy <maximmi@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Björn Töpel <bjorn.topel@...el.com>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Jonathan Lemon <bsd@...com>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [PATCH net-next 2/6] xsk: Add API to check for available entries
 in FQ

On Fri, Apr 26, 2019 at 11:42:33AM +0000, Maxim Mikityanskiy wrote:
> Add a function that checks whether the Fill Ring has the specified
> amount of descriptors available. It will be useful for mlx5e that wants
> to check in advance, whether it can allocate a bulk of RX descriptors,
> to get the best performance.
> 
> Signed-off-by: Maxim Mikityanskiy <maximmi@...lanox.com>
...
> diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
> index a14e8864e4fa..ca764ed9da41 100644
> --- a/net/xdp/xsk.c
> +++ b/net/xdp/xsk.c
> @@ -4,9 +4,11 @@
>   * AF_XDP sockets allows a channel between XDP programs and userspace
>   * applications.
>   * Copyright(c) 2018 Intel Corporation.
> + * Copyright (c) 2019, Mellanox Technologies. All rights reserved.
>   *
>   * Author(s): Björn Töpel <bjorn.topel@...el.com>
>   *	      Magnus Karlsson <magnus.karlsson@...el.com>
> + *	      Maxim Mikityanskiy <maximmi@...lanox.com>

I don't think adding one function makes you an author.
Please remove and remove all copyright lines.
If a file is brand new it's fine to add one, but changes
to existing files do not warrant copyright line additions.