netdev - Re: [PATCH net-next] net: phy: improve genphy_soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190426.115732.1802954717629864003.davem@davemloft.net>
Date:   Fri, 26 Apr 2019 11:57:32 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: improve genphy_soft_reset

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 24 Apr 2019 21:41:06 +0200

> PHY's behave differently when being reset. Some reset registers to
> defaults, some don't. Some trigger an autoneg restart, some don't.
> 
> So let's also set the autoneg restart bit when resetting. Then PHY
> behavior should be more consistent. Clearing BMCR_ISOLATE serves the
> same purpose and is borrowed from genphy_restart_aneg.
> 
> BMCR holds the speed / duplex settings in fixed mode. Therefore
> we may have an issue if a soft reset resets BMCR to its default.
> So better call genphy_setup_forced() afterwards in fixed mode.
> We've seen no related complaint in the last >10 yrs, so let's
> treat it as an improvement.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.