netdev - Re: [PATCH net] net: phy: marvell: Fix buffer overrun with stats counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Apr 2019 12:06:48 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com, hkallweit1@...il.com
Subject: Re: [PATCH net] net: phy: marvell: Fix buffer overrun with stats
 counters

From: Andrew Lunn <andrew@...n.ch>
Date: Thu, 25 Apr 2019 00:33:00 +0200

> marvell_get_sset_count() returns how many statistics counters there
> are. If the PHY supports fibre, there are 3, otherwise two.
> 
> marvell_get_strings() does not make this distinction, and always
> returns 3 strings. This then often results in writing passed the end
> of the buffer for the strings.
> 
> Fixes: 2170fef78a40 ("Marvell phy: add field to get errors from fiber link.")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied and queued up for -stable, thanks!