netdev - Re: [PATCH net-next] net: phy: micrel: make sure the factory test bit is cleared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190426164725.GG4041@lunn.ch>
Date:   Fri, 26 Apr 2019 18:47:25 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Antoine Tenart <antoine.tenart@...tlin.com>
Cc:     davem@...emloft.net, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, nicolas.ferre@...rochip.com,
        ludovic.desroches@...rochip.com, alexandre.belloni@...tlin.com
Subject: Re: [PATCH net-next] net: phy: micrel: make sure the factory test
 bit is cleared

On Fri, Apr 26, 2019 at 06:41:23PM +0200, Antoine Tenart wrote:
> The KSZ8081 PHY has a factory test mode which is set at the de-assertion
> of the reset line based on the RXER (KSZ8081RNA/RND) or TXC
> (KSZ8081MNX/RNB) pin. If a pull-down is missing, or if the pin has a
> pull-up, the factory test mode should be cleared by manually writing a 0
> (according to the datasheet). This patch makes sure this factory test
> bit is cleared in config_init().
> 
> Tested-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew