netdev - Re: [PATCH] net: phy: realtek: Add rtl8211e rx/tx delays config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190426202819.xtzwxjyp6piyuaqz@mobilestation>
Date:   Fri, 26 Apr 2019 23:28:20 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Serge Semin <Sergey.Semin@...latforms.ru>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: realtek: Add rtl8211e rx/tx delays config

On Fri, Apr 26, 2019 at 10:05:21PM +0200, Andrew Lunn wrote:
> > Hello Andrew
> > 
> > Thanks for the comment. I'll alter the code the way you said. The mode will
> > be changed by the config_init-function only if the interface is selected to be
> > rgmii-like (rgmii, rgmii-id, rgmii-txid and rgmii-rxid), otherwise it will
> > be left as is.
> > 
> > But I've got a question regarding this then. What about for instance rtl8211f
> > phy config_init-method? It setups the delay config in any case, no matter
> > whether interface is configured to be of rgmii or another mode. Is it correct
> > to configure rtl8211e and rtl8211f differently? Especially seeing the U-boot
> > driver also perform the rtl8211f phy configuration.
> 
> Hi Sergey
> 
> It is not correct and rtl8211f should be changed. Please add a second
> patch for that.
> 
> We got burnt recently with PHY drivers doing the wrong thing with
> respect to RGMII delays. We have learnt from that experience, but
> there is code in the kernel which still does things wrong.
> 
>       Andrew

Ok. I'll send the updated patchset with rtl8211f_config_init fixed soon.

-Sergey