netdev - Re: [PATCH v3 net-next 06/15] net: aquantia: link status irq handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190426211648.GO4041@lunn.ch>
Date:   Fri, 26 Apr 2019 23:16:48 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Igor Russkikh <Igor.Russkikh@...antia.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Nikita Danilov <Nikita.Danilov@...antia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@...antia.com>
Subject: Re: [PATCH v3 net-next 06/15] net: aquantia: link status irq handling

> +		if (self->aq_nic_cfg.link_irq_vec) {
> +			int irqvec = pci_irq_vector(self->pdev,
> +						   self->aq_nic_cfg.link_irq_vec);
> +			err = request_threaded_irq(irqvec, NULL,
> +						   aq_linkstate_threaded_isr,
> +						   IRQF_SHARED,
> +						   self->ndev->name, self);

At some point you should consider using the devm_* API. It will make
your cleanup code simpler.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew