netdev - Re: [PATCH v3 net-next 10/15] net: aquantia: introduce fwreq mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Apr 2019 23:20:08 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Igor Russkikh <Igor.Russkikh@...antia.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Nikita Danilov <Nikita.Danilov@...antia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@...antia.com>
Subject: Re: [PATCH v3 net-next 10/15] net: aquantia: introduce fwreq mutex

On Fri, Apr 26, 2019 at 09:48:02AM +0000, Igor Russkikh wrote:
> From: Nikita Danilov <ndanilov@...antia.com>
> 
> Some of FW operations could be invoked simultaneously,
> from f.e. ethtool context and from service service activity work.
> Here we introduce a fw mutex to secure and serialize access
> to FW logic.
> 
> Signed-off-by: Nikita Danilov <ndanilov@...antia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@...antia.com>

I still think it would be a good idea to put in the low level code a
check that the mutex is actually held when talking to the firmware.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew