lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190426043809.GC2271@nanopsycho.orion> Date: Fri, 26 Apr 2019 06:38:09 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Jakub Kicinski <jakub.kicinski@...ronome.com> Cc: Moshe Shemesh <moshe@...lanox.com>, "David S. Miller" <davem@...emloft.net>, Jiri Pirko <jiri@...lanox.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next] devlink: Execute devlink health recover as a work Thu, Apr 25, 2019 at 11:38:47PM CEST, jakub.kicinski@...ronome.com wrote: >On Thu, 25 Apr 2019 13:57:03 +0300, Moshe Shemesh wrote: >> Different reporters have different rules in the driver and are being >> created/destroyed during different stages of driver load/unload/running. >> So during execution of a reporter recover the flow can go through >> another reporter's destroy and create. Such flow leads to deadlock >> trying to lock a mutex already held if the flow was triggered by devlink >> recover command. >> To avoid such deadlock, we execute the recover flow from a workqueue. >> Once the recover work is done successfully the reporter health state and >> recover counter are being updated. > >Naive question, why not just run the doit unlocked? Why the async? Hmm, you have a point here. That would be probably doable.
Powered by blists - more mailing lists