lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 26 Apr 2019 01:52:20 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     jiri@...nulli.us, netdev@...r.kernel.org, mlxsw@...lanox.com,
        dsahern@...il.com
Subject: Re: [patch net-next v4 00/16] netdevsim: implement proper device
 model

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Thu, 25 Apr 2019 15:11:17 -0700

> On Thu, 25 Apr 2019 15:59:40 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> Currently the model of netdevsim is a bit odd in multiple ways.
>> 1) devlink instance is not in any way related with actual netdevsim
>>    netdevices. Instead, it is created per-namespace.
>> 2) multi-port netdevsim device is done using "link" attribute.
>> 3) netdevsim bus is there only to have something to bind the netdev to,
>>    it really does not act as a bus.
>> 4) netdevsim instances are created by "ip link add" which is great for
>>    soft devices with no hw backend. The rtnl core allocates netdev and
>>    calls into driver holding rtnl mutex. For hw-backed devices, this
>>    flow is wrong as it breaks order in which things are done.
>> 
>> This patchset adjust netdevsim to fix all above.
> 
> Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Series applied, thanks everyone.

Powered by blists - more mailing lists