netdev - Re: [PATCH v2 0/5] strict netlink validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4645a8a-d48d-2e30-a7fd-17f2ffa0157b@cumulusnetworks.com>
Date:   Fri, 26 Apr 2019 20:28:20 -0600
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Johannes Berg <johannes@...solutions.net>, netdev@...r.kernel.org
Cc:     Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH v2 0/5] strict netlink validation

On 4/26/19 6:07 AM, Johannes Berg wrote:
> Here's a respin, with the following changes:
>  * change message when rejecting unknown attribute types (David Ahern)
>  * drop nl80211 patch - I'll apply it separately
>  * remove NL_VALIDATE_POLICY - we have a lot of calls to nla_parse()
>    that really should be without a policy as it has previously been
>    validated - need to find a good way to handle this later
>  * include the correct generic netlink change (d'oh, sorry)
> 
> johannes
> 
> 

I agree with this set and will help moving forward. As I recall it
requires follow up patches for each policy to set strict_start_type
opting in to the strict checking. With that in place new userspace on
old kernels will get a failure trying to configure a feature the old
kernel does not recognize.

For the series:
Acked-by: David Ahern <dsahern@...il.com>