lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190427163923.GC9816@lunn.ch> Date: Sat, 27 Apr 2019 18:39:23 +0200 From: Andrew Lunn <andrew@...n.ch> To: Petr Štetiar <ynezz@...e.cz> Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Heiko Stuebner <heiko@...ech.de>, Fugang Duan <fugang.duan@....com>, Claudiu Manoil <claudiu.manoil@....com>, Yisen Zhuang <yisen.zhuang@...wei.com>, Salil Mehta <salil.mehta@...wei.com>, Woojung Huh <woojung.huh@...rochip.com>, Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>, Neil Armstrong <narmstrong@...libre.com>, Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>, Masahiro Yamada <yamada.masahiro@...ionext.com>, Jassi Brar <jaswinder.singh@...aro.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...com>, Kalle Valo <kvalo@...eaurora.org>, Matthias Brugger <matthias.bgg@...il.com>, Li Yang <leoyang.li@....com>, Heiner Kallweit <hkallweit1@...il.com>, Frank Rowand <frowand.list@...il.com>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Maxime Ripard <maxime.ripard@...tlin.com>, Alban Bedel <albeu@...e.fr>, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-oxnas@...ups.io, linux-stm32@...md-mailman.stormreply.com, linux-wireless@...r.kernel.org, linux-mediatek@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org Subject: Re: [PATCH 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour > diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt > index 8b80515..92c5642 100644 > --- a/Documentation/devicetree/bindings/net/macb.txt > +++ b/Documentation/devicetree/bindings/net/macb.txt > @@ -26,15 +26,15 @@ Required properties: > Optional elements: 'tsu_clk' > - clocks: Phandles to input clocks. > > -Optional properties: > -- nvmem-cells: phandle, reference to an nvmem node for the MAC address > -- nvmem-cell-names: string, should be "mac-address" if nvmem is to be used > - > Optional properties for PHY child node: > - reset-gpios : Should specify the gpio for phy reset > - magic-packet : If present, indicates that the hardware supports waking > up via magic packet. > - phy-handle : see ethernet.txt file in the same directory > +- mac-address: See ethernet.txt in the same directory. > +- local-mac-address: See ethernet.txt in the same directory. > +- nvmem-cells: See ethernet.txt in the same directory. > +- nvmem-cell-names: See ethernet.txt in the same directory. This looks wrong. The MAC address is not a PHY property, so should not be inside the PHY child node. phy-handle is in the wrong place, but that is a separate problem. Andrew
Powered by blists - more mailing lists