lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Apr 2019 23:36:40 +0200 From: Andrew Lunn <andrew@...n.ch> To: Petr Štetiar <ynezz@...e.cz> Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Nicolas Ferre <nicolas.ferre@...rochip.com>, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, Rob Herring <robh+dt@...nel.org>, Frank Rowand <frowand.list@...il.com>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Maxime Ripard <maxime.ripard@...tlin.com>, Alban Bedel <albeu@...e.fr> Subject: Re: [PATCH v2 3/4] net: macb: Drop nvmem_get_mac_address usage > so if I understand this correctly, it probably means, that this approach with > modified of_get_mac_address is dead end as current of_get_mac_address users > don't expect and handle possible -EPROBE_DEFER error, so I would need to > change all the current users, which is nonsense. Hi Petr I would not say it is dead, it just needs a bit more work. The current users should always be checking for a NULL pointer. You just need to change that to !IS_ERR(). You can then return ERR_PTR(-PROBE_DEFER) from the NVMEM operation. And i agree, wrapping this all up inside of_get_mac_address() is the correct way to do this. Andrew
Powered by blists - more mailing lists