lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Apr 2019 19:04:56 +0200 From: Andrew Lunn <andrew@...n.ch> To: Heiner Kallweit <hkallweit1@...il.com> Cc: Florian Fainelli <f.fainelli@...il.com>, David Miller <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net-next] net: phy: improve setting advertised modes in phy_probe On Sun, Apr 28, 2019 at 03:03:37PM +0200, Heiner Kallweit wrote: > So far we set the advertising bitmap before setting the pause flags > in the supported bitmap. This may cause pause not being advertised. Hi Heiner Pause requires that the PHY can advertise the pause bits, and that the MAC supports pause. So by default, we don't advertise pause. The MAC needs to say it supports pause, by calling one of void phy_support_sym_pause(struct phy_device *phydev); void phy_support_asym_pause(struct phy_device *phydev); These two then copy supported into advertising. Andrew
Powered by blists - more mailing lists