netdev - Re: [PATCH net] ipv4: Fix updating SOF_TIMESTAMPING_OPT_ID when SKBTX_HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-JLcmyoJ6tq1osgrQbXs6+As0R+J-ofU+XwQWcvaW+LBg@mail.gmail.com>
Date:   Sun, 28 Apr 2019 22:57:57 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     Stephen Mallon <stephen.mallon@...ney.edu.au>,
        "David S. Miller" <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH net] ipv4: Fix updating SOF_TIMESTAMPING_OPT_ID when
 SKBTX_HW_TSTAMP is enabled

On Sun, Apr 28, 2019 at 11:22 AM Richard Cochran
<richardcochran@...il.com> wrote:
>
> On Sun, Apr 28, 2019 at 03:45:21PM +1000, Stephen Mallon wrote:
> > Ensure that the unique timestamp identifier is incremented for skb hardware
> > timestamps, not just software timestamps.
>
> Thanks for fixing this.  It has been at the back of my mind for a long
> time, but since I don't use this feature... oh well.
>
> This patch would be a candidate for stable kernels.  Can you please
> add a Fixes: tag?

It is debatable whether this is a fix or a new feature. It extends
SOF_TIMESTAMPING_OPT_ID to hardware timestamps. I don't think this
would be a stable candidate.

More importantly, note that __ip6_append_data has similar logic. For
consistency the two should be updated at the same time.