netdev - Re: [PATCH iproute2-next] tc: add support for plug qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190429101638.1a250c01@hermes.lan>
Date:   Mon, 29 Apr 2019 10:16:38 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] tc: add support for plug qdisc

On Fri, 26 Apr 2019 10:47:52 +0200
Paolo Abeni <pabeni@...hat.com> wrote:

> Hi,
> 
> On Wed, 2019-04-24 at 13:49 -0700, Stephen Hemminger wrote:
> > On Wed, 24 Apr 2019 18:29:39 +0200
> > Paolo Abeni <pabeni@...hat.com> wrote:
> >   
> > > +static int plug_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
> > > +{
> > > +	/* dummy implementation as sch_plug does not implement a dump op */
> > > +	return 0;
> > > +}
> > > +  
> > 
> > All qdisc must dump their state in same form as the parse option.  
> 
> Thank you for the feedback. 
> 
> The problem here is that the sch_plug qdisc does not implement the
> dump() qdisc_op, so this callback has nothing to dump.
> 
> Must I patch sch_plug first?
> 
> Thanks,
> 
> Paolo
> 

OK, lets put the patch in as is for now. And then fix the kernel, then add print?