netdev - Re: [PATCH net-next 10/13] net: dsa: Skip calling .port_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Apr 2019 23:57:10 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     f.fainelli@...il.com, vivien.didelot@...il.com,
        davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 10/13] net: dsa: Skip calling
 .port_vlan_filtering on no change

On Sun, Apr 28, 2019 at 09:45:51PM +0300, Vladimir Oltean wrote:
> Even if VLAN filtering is global, DSA will call this callback once per
> each port. Drivers should not have to compare the global state with the
> requested change. So let DSA do it.
> 
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew