netdev - Re: [PATCH net] ipv6: invert flowlabel sharing check in process and user mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190429.182419.1714394273539373115.davem@davemloft.net>
Date:   Mon, 29 Apr 2019 18:24:19 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, ebiederm@...ssion.com, willemb@...gle.com
Subject: Re: [PATCH net] ipv6: invert flowlabel sharing check in process
 and user mode

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Thu, 25 Apr 2019 12:06:54 -0400

> From: Willem de Bruijn <willemb@...gle.com>
> 
> A request for a flowlabel fails in process or user exclusive mode must
> fail if the caller pid or uid does not match. Invert the test.
> 
> Previously, the test was unsafe wrt PID recycling, but indeed tested
> for inequality: fl1->owner != fl->owner
> 
> Fixes: 4f82f45730c68 ("net ip6 flowlabel: Make owner a union of struct pid* and kuid_t")
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied and queued up for -stable, thanks Willem.