lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Apr 2019 09:18:41 +0200 From: Alexandre Torgue <alexandre.torgue@...com> To: Biao Huang <biao.huang@...iatek.com>, Jose Abreu <joabreu@...opsys.com>, <davem@...emloft.net> CC: Giuseppe Cavallaro <peppe.cavallaro@...com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Matthias Brugger <matthias.bgg@...il.com>, <netdev@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>, <yt.shen@...iatek.com>, <jianguo.zhang@...iatek.com> Subject: Re: [PATCH 2/6] net: stmmac: fix csr_clk can't be zero issue Hi On 4/28/19 8:30 AM, Biao Huang wrote: > The specific clk_csr value can be zero, and > stmmac_clk is necessary for MDC clock which can be set dynamically. > So, change the condition from plat->clk_csr to plat->stmmac_clk to > fix clk_csr can't be zero issue. > > Signed-off-by: Biao Huang <biao.huang@...iatek.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 818ad88..9e89b94 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -4376,7 +4376,7 @@ int stmmac_dvr_probe(struct device *device, > * set the MDC clock dynamically according to the csr actual > * clock input. > */ > - if (!priv->plat->clk_csr) > + if (priv->plat->stmmac_clk) > stmmac_clk_csr_set(priv); > else > priv->clk_csr = priv->plat->clk_csr; > So, as soon as stmmac_clk will be declared, it is no longer possible to fix a CSR through the device tree ?
Powered by blists - more mailing lists