netdev - Re: [PATCH v3 net-next 1/3] ipv4: Move cached routes to fib_nh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <822f60dd-a206-827e-ad26-b867ffd2e507@gmail.com>
Date:   Tue, 30 Apr 2019 08:27:23 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>,
        David Ahern <dsahern@...nel.org>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 net-next 1/3] ipv4: Move cached routes to fib_nh_common

On 4/30/19 12:40 AM, Ido Schimmel wrote:
> On Mon, Apr 29, 2019 at 09:16:17AM -0700, David Ahern wrote:
>>  /* Release a nexthop info record */
>> @@ -491,9 +491,15 @@ int fib_nh_common_init(struct fib_nh_common *nhc, struct nlattr *encap,
>>  		       u16 encap_type, void *cfg, gfp_t gfp_flags,
>>  		       struct netlink_ext_ack *extack)
>>  {
>> +	int err;
>> +
>> +	nhc->nhc_pcpu_rth_output = alloc_percpu_gfp(struct rtable __rcu *,
>> +						    gfp_flags);
>> +	if (!nhc->nhc_pcpu_rth_output)
>> +		return -ENOMEM;
>> +
>>  	if (encap) {
>>  		struct lwtunnel_state *lwtstate;
>> -		int err;
>>  
>>  		if (encap_type == LWTUNNEL_ENCAP_NONE) {
>>  			NL_SET_ERR_MSG(extack, "LWT encap type not specified");
> 
> Failure here will leak 'nhc->nhc_pcpu_rth_output'
> 

ugh, thanks for catching that.