netdev - Re: [PATCH] net: dsa: bcm_sf2: fix buffer overflow doing set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190430.110425.1977792345336253148.davem@davemloft.net>
Date:   Tue, 30 Apr 2019 11:04:25 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net: dsa: bcm_sf2: fix buffer overflow doing set_rxnfc

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Tue, 30 Apr 2019 13:44:19 +0300

> The "fs->location" is a u32 that comes from the user in ethtool_set_rxnfc().
> We can't pass unclamped values to test_bit() or it results in an out of
> bounds access beyond the end of the bitmap.
> 
> Fixes: 7318166cacad ("net: dsa: bcm_sf2: Add support for ethtool::rxnfc")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied and queued up for -stable, thanks Dan.