[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <15B5FD82-D048-416F-9D1E-7F2B675100DA@flugsvamp.com>
Date: Tue, 30 Apr 2019 08:38:49 -0700
From: "Jonathan Lemon" <jlemon@...gsvamp.com>
To: "Björn Töpel" <bjorn.topel@...il.com>
Cc: ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org,
magnus.karlsson@...el.com, magnus.karlsson@...il.com,
bpf@...r.kernel.org, u9012063@...il.com
Subject: Re: [PATCH bpf 0/2] libbpf: fixes for AF_XDP teardown
On 30 Apr 2019, at 5:45, Björn Töpel wrote:
> William found two bugs, when doing socket teardown within the same
> process.
>
> The first issue was an invalid munmap call, and the second one was an
> invalid XSKMAP cleanup. Both resulted in that the process kept
> references to the socket, which was not correctly cleaned up. When a
> new socket was created, the bind() call would fail, since the old
> socket was still lingering, refusing to give up the queue on the
> netdev.
>
> More details can be found in the individual commits.
Reviewed-by: Jonathan Lemon <jonathan.lemon@...il.com>
Powered by blists - more mailing lists