netdev - Re: [PATCH net] selftests: fib_rule_tests: Fix icmp proto with ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190430023740.GJ18865@dhcp-12-139.nay.redhat.com>
Date:   Tue, 30 Apr 2019 10:37:40 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     David Ahern <dsahern@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net] selftests: fib_rule_tests: Fix icmp proto with ipv6

On Mon, Apr 29, 2019 at 10:30:09AM -0700, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> A recent commit returns an error if icmp is used as the ip-proto for
> IPv6 fib rules. Update fib_rule_tests to send ipv6-icmp instead of icmp.
> 
> Fixes: 5e1a99eae8499 ("ipv4: Add ICMPv6 support when parse route ipproto")
> Signed-off-by: David Ahern <dsahern@...il.com>

Yes, I also found this issue and have the same patch in my pipeline...

There are two other issues with the fib_rules_tests. The first is the test
didn't check the nfail and will always return 0. I will post the fix later.

An other issue is The IPv4 rule 'from iif' check test failed while IPv6
passed. I haven't found out the reason yet.

# ip -netns testns rule add from 192.51.100.3 iif dummy0 table 100
# ip -netns testns route get 192.51.100.2 from 192.51.100.3 iif dummy0
RTNETLINK answers: No route to host

    TEST: rule4 check: from 192.51.100.3 iif dummy0           [FAIL]

# ip -netns testns -6 rule add from 2001:db8:1::3 iif dummy0 table 100
# ip -netns testns -6 route get 2001:db8:1::2 from 2001:db8:1::3 iif dummy0
2001:db8:1::2 via 2001:db8:1::2 dev dummy0 table 100 metric 1024 iif dummy0 pref medium

    TEST: rule6 check: from 2001:db8:1::3 iif dummy0          [ OK ]

Thanks
Hangbin