[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1f1ca56d-bfd7-7fc4-1fed-cff2cc69c6f7@akamai.com>
Date: Tue, 30 Apr 2019 11:55:09 -0700
From: Josh Hunt <johunt@...mai.com>
To: David Ahern <dsahern@...il.com>, stephen@...workplumber.org
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] ss: add option to print socket information
on one line
On 4/30/19 11:31 AM, Josh Hunt wrote:
> On 4/30/19 11:30 AM, David Ahern wrote:
>> On 4/25/19 3:21 PM, Josh Hunt wrote:
>>> @@ -4877,6 +4903,7 @@ static void _usage(FILE *dest)
>>> "\n"
>>> " -K, --kill forcibly close sockets, display what was
>>> closed\n"
>>> " -H, --no-header Suppress header line\n"
>>> +" -O, --one-line socket's data printed on a single line\n"
>>> "\n"
>>> " -A, --query=QUERY, --socket=QUERY\n"
>>> " QUERY :=
>>> {all|inet|tcp|udp|raw|unix|unix_dgram|unix_stream|unix_seqpacket|packet|netlink|vsock_stream|vsock_dgram|tipc}[,QUERY]\n"
>>>
>>> @@ -5003,6 +5030,7 @@ static const struct option long_opts[] = {
>>> { "kill", 0, 0, 'K' },
>>> { "no-header", 0, 0, 'H' },
>>> { "xdp", 0, 0, OPT_XDPSOCK},
>>> + { "one-line", 0, 0, 'O' },
>>
>> shame 'o' can not be used for consistency with ip, but we can have both
>> use 'oneline' as the long option without the '-'.
>>
>
> Yeah, thanks David. I saw that the other tools use --oneline, so I'll
> send an update with that changed.
>
Actually, David can you clarify what you meant by "use 'oneline' as the
long option without the '-'."?
Thanks
Josh
Powered by blists - more mailing lists