netdev - Re: [PATCH] netfilter: fix nf_l4proto_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA42JLbgEBMmzYTBtDyVh7iBQ7QDvzOwo47BRfYEssEE3QKzfg@mail.gmail.com>
Date:   Mon, 29 Apr 2019 23:38:36 -0700
From:   Dexuan-Linux Cui <dexuan.linux@...il.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     Andrei Vagin <avagin@...il.com>, Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
        Dexuan Cui <decui@...rosoft.com>
Subject: Re: [PATCH] netfilter: fix nf_l4proto_log_invalid to log invalid packets

On Mon, Apr 22, 2019 at 1:40 AM Pablo Neira Ayuso <pablo@...filter.org> wrote:
>
> On Wed, Apr 17, 2019 at 09:49:44AM -0700, Andrei Vagin wrote:
> > It doesn't log a packet if sysctl_log_invalid isn't equal to protonum
> > OR sysctl_log_invalid isn't equal to IPPROTO_RAW. This sentence is
> > always true. I believe we need to replace OR to AND.
>
> Applied, thanks.

I also happened to find this bug today.
I almost can not believe I'm the second guy to notice the issue -- the
bug has been there for 1 year and a half...

Anyway, I'm glad to see that Andrei fixed it!

-- Dexuan