netdev - Re: [PATCH net v2] packet: validate msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190501.113109.1671453363452745363.davem@davemloft.net>
Date:   Wed, 01 May 2019 11:31:09 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, David.Laight@...lab.com, willemb@...gle.com
Subject: Re: [PATCH net v2] packet: validate msg_namelen in send directly

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Mon, 29 Apr 2019 11:53:18 -0400

> From: Willem de Bruijn <willemb@...gle.com>
> 
> Packet sockets in datagram mode take a destination address. Verify its
> length before passing to dev_hard_header.
> 
> Prior to 2.6.14-rc3, the send code ignored sll_halen. This is
> established behavior. Directly compare msg_namelen to dev->addr_len.
> 
> Change v1->v2: initialize addr in all paths
> 
> Fixes: 6b8d95f1795c4 ("packet: validate address length if non-zero")
> Suggested-by: David Laight <David.Laight@...lab.com>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied and queued up for -stable.